-
-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc prompt #1031
Doc prompt #1031
Conversation
Please, take a look at CONTRIBUTING.md (I'm referring to the commit message format in particular). |
Another thing - I can imagine some people actually like the current behaviour, so I'd suggest a config option to toggle between the two. |
That might be tricky in light of the proposed |
OK. sorry about that. I thought about an option to turn it on and off, but that does prevent more useful prefix behaviors like jump to var other window. This does cause the behavior to match that of many other emacs packages, where the current behavior is mostly frustrating. Hitting return once is a lot easier than typing C-u prefix after figuring out that is what you need to do. |
Fair enough. Let's see the feedback we'll get. For now just update the commits and mention this in the changelog. |
What is your preference for connecting the changelog, the issue and the pull request together? |
@EricGebhart I opened an issue about |
@expez That one is on my radar. I'm in the middle of all that code anyway. Learning my way around... |
|
@EricGebhart Commit message titles are titles (meaning they should not end with I'm sorry if I sound picky, but I care about every detail. |
cider-doc, cider-grimoire, jump-to-var and other functions using cider-read-symbol-name were not interactive without a prefix or missing symbol. cider-read-symbol-name now prompts with the symbol at point as a default.
It's ok. All the periods are gone. I'll be sure to leave them off in the future. |
👍 |
Please revert this commit, for the reasons I give in the thread in #1014 |
@bbatsov, since you said above "Let's see the feedback we'll get" - I second @malcolmsparks . Sorry, but I really hate the new behavior. Having to type RET after every M-. is very clunky. |
I also am finding this rather annoying. I understand there are arguments for this behaviour, so I would settle for the ability to configure it. |
You can now set |
This is changes the behavior of the doc functions to always prompt with a default of symbol at point. The prompts were given contextual labels instead of 'Symbol:' where needed.